Fix absolute paths #203
Merged
Fix absolute paths #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/CC @sindresorhus |
| @@ -1,4 +1,7 @@ | |||
| 'use strict'; | |||
| function absolutePath(path) { | |||
| return __dirname + '/' + path; | |||
|
Good points. Do you mind if I just amend the existing commit, or would you prefer a separate one? |
|
@smcgivern: just amend. |
smcgivern
force-pushed
the
fix_absolute_paths
branch
from
81586b2 to
4deac5b
Compare
|
OK, done 👍 |
|
I know this is already merged, but.. Why are you setting: When it should be relative to the destination: |
|
Honestly, because it was like that before: grunt-contrib-cssmin/tasks/cssmin.js Line 45 in 4af3941 This also isn't merged - @XhmikosR a little help please? 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #191 and maybe #196 too.
The
relativeTooption was removed at https://github.com/gruntjs/grunt-contrib-cssmin/pull/170/files#diff-f0ee9eb300066e1e51fcfbad9d7a78e1L45 and seemingly never added back.